MET-685: Add new parameters #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
danenbm
reviewed
Mar 24, 2025
Comment on lines
+107
to
+110
| 'https://gateway.irys.xyz/8da3Er9Q39QRkdNhBNP7w5hDo5ZnydLNxLqe9i6s1Nak', | ||
| // TODO: Needs to be added again after MTG-1380 is merged | ||
| // description: '', | ||
| // external_url: '' |
There was a problem hiding this comment.
Is this still a TODO? Can you confirm whether its merged/deployed?
There was a problem hiding this comment.
This one is blocked by MTG-1493
I’d propose to merge it with that to do and fix it in one of the agreed follow up PRs
Comment on lines
+113
to
+122
| // Assert the asset exists and has group_definition | ||
| t.truthy(specificAsset, 'Expected to find the specific asset'); | ||
| if (specificAsset) { | ||
| t.is( | ||
| (specificAsset as any).group_definition, | ||
| undefined, | ||
| 'Expected group_definition to be undefined when showUnverifiedCollections is true' | ||
| ); | ||
| } | ||
| }); |
There was a problem hiding this comment.
Isn't this one supposed to be the case where the collection is shown but just as unverified?
There was a problem hiding this comment.
Here's the test coverage as I see it:
| Method | showUnverifiedCollections: true |
showUnverifiedCollections: false |
showCollectionMetadata: true |
showFungible: true |
onlyVerified: true |
onlyVerified: false |
|---|---|---|---|---|---|---|
getAsset |
✅ | ✅ | ❌ | ❌ | ❌ | ❌ |
getAssets |
✅ | ❌ | ✅ | ✅ | ❌ | ❌ |
getAssetsByAuthority |
✅ | ✅ | ✅ | ❌ | ❌ | ❌ |
getAssetsByCreator |
✅ | ✅ | ✅ | ❌ | ✅ | ✅ |
getAssetsByGroup |
✅ | ✅ | ✅ | ❌ | ❌ | ❌ |
getAssetsByOwner |
✅ | ❌ | ✅ | ✅ | ❌ | ❌ |
searchAssets |
✅ | ✅ | ❌ | ❌ | ❌ | ❌ |
Looks like everything is covered to some degree except showInscription which maybe is fine if we don't easily have those assets to test with.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding displayOptions for